From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Fri, 2 Aug 2013 04:38:59 +0000 (-0400)
Subject: messageTray: Remove an extraneous show
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3731
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=12b7e56261b46d93581b5b722d336a2244a51293;p=gnome-shell.git

messageTray: Remove an extraneous show

This means that the close button also does not have to be public.
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 7b61d11b6..250c11295 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -1406,12 +1406,12 @@ const SummaryItem = new Lang.Class({
         this.notificationStackView.add_actor(this.notificationStack);
         this.notificationStackWidget.add_actor(this.notificationStackView);
 
-        this.closeButton = Util.makeCloseButton();
-            this.closeButton.connect('clicked', Lang.bind(this, function() {
+        this._closeButton = Util.makeCloseButton();
+        this._closeButton.connect('clicked', Lang.bind(this, function() {
             source.destroy();
             source.emit('done-displaying-content');
         }));
-        this.notificationStackWidget.add_actor(this.closeButton);
+        this.notificationStackWidget.add_actor(this._closeButton);
         this._stackedNotifications = [];
 
         this._oldMaxScrollAdjustment = 0;
@@ -2666,12 +2666,8 @@ const MessageTray = new Lang.Class({
         if (this._clickedSummaryItemMouseButton == 1) {
             // Acknowledge all our notifications
             summaryItem.source.notifications.forEach(function(n) { n.acknowledged = true; });
-
-            child = summaryItem.notificationStackWidget;
-
-            let closeButton = summaryItem.closeButton;
-            closeButton.show();
             summaryItem.prepareNotificationStackForShowing();
+            child = summaryItem.notificationStackWidget;
         } else if (this._clickedSummaryItemMouseButton == 3) {
             child = summaryItem.rightClickMenu;
         }